Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pos validator uptime #2379

Merged
merged 39 commits into from
Dec 12, 2024
Merged

Pos validator uptime #2379

merged 39 commits into from
Dec 12, 2024

Conversation

arturrez
Copy link
Collaborator

Why this should be merged

adds PoS proof of uptime support for removeValitor

How this works

if uptime is not provided, it's calculated from evm getCurrentValdators api.
Signature aggregator is used to sign proof of uptime msg which is submitted to ValidatorManager smart contract

How this was tested

./bin/avalanche node local start  --num-nodes 7 --etna-devnet local7
./bin/avalanche blockchain create pos7 --proof-of-stake  --force  --evm --reward-basis-points 10000000 // make sure that validator gets reward even after short staking period
./bin/avalanche blockchain deploy pos7 --cluster local7 --bootstrap-endpoints http://127.0.0.1:9650/,http://127.0.0.1:9652/,http://127.0.0.1:9654/,http://127.0.0.1:9656/,http://127.0.0.1:9658/  --convert-only
./bin/avalanche node local track local7 pos7
./bin/avalanche contract initValidatorManager pos7  --cluster local7
./bin/avalanche blockchain addValidator pos7  --cluster local7 --node-endpoint http://127.0.0.1:9660
sleep 120s
./bin/avalanche blockchain removeValidator pos7  --cluster local7 --node-endpoint http://127.0.0.1:9660

How is this documented

@arturrez arturrez requested a review from a team as a code owner November 27, 2024 00:13
arturrez and others added 20 commits November 27, 2024 09:45
@arturrez
increase staking reward
f29392c
@arturrez
fix typo
2be7ae2
@arturrez
add uptime deductible
ed76795
@arturrez
add debug output to e2e
b3e7089
@arturrez
increse PoS e2e validator balance
c0e30a3
@arturrez
proper e2e addvalidator config
c1d7415
@arturrez
reduce stake amount
9448b5e
@arturrez
disable this check for now
f9f2d37
@arturrez
increase wait time for reward
326d3d9
@arturrez
adjust params
aa419d1
@arturrez
add manual uptime for e2e
03e87c2
@arturrez
fix
74ccf05
@arturrez
5 mins before status
4ea0625
@arturrez
rm sleep and e2e for check rm validator with uptime
b548755
@arturrez
Merge branch 'main' into pos-validator-uptime
ce2db5c
@arturrez
Merge branch 'main' into pos-validator-uptime
6d04aff
@arturrez
add force flag to remove validators. allow validator removal with 0 r…
71c894d 
…eward
@arturrez
add check for failed removal and also sleep in e2e waiting for min du…
89654f9 
…ration to pass
@arturrez
rm e2e check - no cli value
4082bdc
@arturrez
minor refactor
5b8c0ba
@meaghanfitzgerald meaghanfitzgerald linked an issue Dec 4, 2024 that may be closed by this pull request
Enable L1 Validator Removal Using Uptime Tracking #2394
Closed
felipemadero
felipemadero reviewed Dec 11, 2024
View reviewed changes
pkg/utils/net.go Outdated Show resolved Hide resolved
pkg/utils/net.go Outdated Show resolved Hide resolved
pkg/utils/net_test.go Show resolved Hide resolved
pkg/utils/staking.go Outdated Show resolved Hide resolved
pkg/utils/staking.go Outdated Show resolved Hide resolved
pkg/utils/staking.go Outdated Show resolved Hide resolved
pkg/utils/staking.go Outdated Show resolved Hide resolved
pkg/validatormanager/validatormanager.go Outdated Show resolved Hide resolved
cmd/blockchaincmd/remove_validator.go Show resolved Hide resolved
cmd/blockchaincmd/remove_validator.go Outdated Show resolved Hide resolved
This was referenced Dec 11, 2024
Open
Open
@arturrez arturrez merged commit 76ccb76 into main Dec 12, 2024
37 checks passed
@arturrez arturrez deleted the pos-validator-uptime branch December 12, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipemadero felipemadero felipemadero approved these changes

@sukantoraymond sukantoraymond Awaiting requested review from sukantoraymond sukantoraymond is a code owner automatically assigned from ava-labs/tooling

Assignees
No one assigned
Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable L1 Validator Removal Using Uptime Tracking
3 participants
@arturrez @felipemadero @sukantoraymond